feat: minor UI adjustments

This commit is contained in:
Xiaohan-Tian
2026-06-02 22:31:29 -07:00
parent 5aacf01457
commit 4bdd0d5ea7
7 changed files with 593 additions and 7 deletions
+87
View File
@@ -398,12 +398,99 @@
font-weight: bold; font-weight: bold;
} }
.message-tool-result-title,
.message-tool-summary {
margin: 4px 0;
}
.message-tool-summary {
display: flex;
align-items: flex-start;
gap: 0;
}
.message-tool-summary-prefix {
white-space: pre;
flex: 0 0 auto;
}
.message-tool-summary-content {
flex: 1 1 auto;
}
.message-tool-summary-content > :first-child {
margin-top: 0;
}
.message-tool-summary-content > :last-child {
margin-bottom: 0;
}
.message-performance-info { .message-performance-info {
margin-top: 8px; margin-top: 8px;
font-size: 10px; font-size: 10px;
color: #909090; color: #909090;
} }
.tool-call-code-block {
position: relative;
margin: 8px 0;
}
.tool-call-code-block-inner {
overflow: hidden;
transition: max-height 0.24s ease;
}
.tool-call-code-block-inner > div {
margin: 0 !important;
}
.tool-call-code-block-inner pre {
margin: 0 !important;
overflow-x: auto !important;
overflow-y: hidden !important;
}
.tool-call-code-block-toggle {
position: absolute;
left: 0;
right: 0;
bottom: 0;
display: flex;
align-items: flex-end;
justify-content: center;
width: 100%;
padding: 0;
border: 0;
background: transparent;
cursor: pointer;
}
.tool-call-code-block-toggle-content {
position: relative;
z-index: 1;
display: inline-flex;
align-items: center;
gap: 8px;
padding: 20px 12px 10px;
color: #d7e7f6;
font-size: 11px;
font-weight: 600;
}
.tool-call-code-block-toggle:hover .tool-call-code-block-toggle-content {
color: #f0f7ff;
}
.tool-call-code-block-fade {
position: absolute;
left: 0;
right: 0;
bottom: 0;
background: linear-gradient(180deg, rgba(26, 26, 26, 0) 0%, rgba(26, 26, 26, 0.92) 58%, #1a1a1a 100%);
}
.message-divider-banner { .message-divider-banner {
display: flex; display: flex;
align-items: center; align-items: center;
+3
View File
@@ -527,7 +527,10 @@ const ChatBox: React.FC<ChatBoxProps> = ({ isVisible }) => {
performanceInfo={message.performanceInfo} performanceInfo={message.performanceInfo}
toolName={message.toolName} toolName={message.toolName}
toolSuccess={message.toolSuccess} toolSuccess={message.toolSuccess}
toolRawResult={message.toolRawResult}
toolResultDisplayContent={message.toolResultDisplayContent}
todoSnapshot={message.todoSnapshot} todoSnapshot={message.todoSnapshot}
isToolCallMessage={message.isToolCallMessage}
onAbort={message.isStreaming ? handleAbort : undefined} onAbort={message.isStreaming ? handleAbort : undefined}
/> />
) )
@@ -6,6 +6,7 @@ import type { TodoItem } from '../../agent/core/todo';
describe('AssistantMessage', () => { describe('AssistantMessage', () => {
afterEach(() => { afterEach(() => {
vi.useRealTimers(); vi.useRealTimers();
vi.restoreAllMocks();
}); });
it.each([ it.each([
@@ -95,6 +96,68 @@ describe('AssistantMessage', () => {
expect(codeElement).toHaveTextContent('const value = 1;'); expect(codeElement).toHaveTextContent('const value = 1;');
}); });
it('keeps non-tool-call code blocks rendered without the expander', () => {
const { container } = render(
<AssistantMessage content={'```json\n{"foo": 1}\n```'} />
);
expect(container.querySelector('[data-testid="tool-call-code-block"]')).not.toBeInTheDocument();
expect(screen.queryByRole('button', { name: 'Click to expand' })).not.toBeInTheDocument();
});
it('collapses long tool-call code blocks and expands them in place', () => {
vi.spyOn(HTMLElement.prototype, 'scrollHeight', 'get').mockReturnValue(280);
vi.stubGlobal('requestAnimationFrame', (callback: FrameRequestCallback) => {
callback(0);
return 0;
});
const { container } = render(
<div className="chatbox-messages">
<AssistantMessage
content={'🔧 **Calling tool: add_notes**\n\n```json\n{\n "notes": []\n}\n```'}
isToolCallMessage={true}
/>
</div>
);
const toolCallBlock = screen.getByTestId('tool-call-code-block');
const toolCallInner = container.querySelector('.tool-call-code-block-inner') as HTMLDivElement;
expect(toolCallBlock).toBeInTheDocument();
expect(toolCallInner.style.maxHeight).toBe('200px');
expect(screen.getByRole('button', { name: 'Click to expand' })).toBeInTheDocument();
fireEvent.click(screen.getByRole('button', { name: 'Click to expand' }));
expect(screen.getByRole('button', { name: 'Click to collapse' })).toBeInTheDocument();
expect(toolCallInner.style.maxHeight).toBe('280px');
});
it('preserves chat scroll position when expanding a tool-call block', () => {
vi.spyOn(HTMLElement.prototype, 'scrollHeight', 'get').mockReturnValue(320);
vi.stubGlobal('requestAnimationFrame', (callback: FrameRequestCallback) => {
callback(0);
return 0;
});
render(
<div className="chatbox-messages">
<AssistantMessage
content={'🔧 **Calling tool: add_notes**\n\n```json\n{\n "notes": []\n}\n```'}
isToolCallMessage={true}
/>
</div>
);
const scrollContainer = document.querySelector('.chatbox-messages') as HTMLDivElement;
scrollContainer.scrollTop = 96;
fireEvent.click(screen.getByRole('button', { name: 'Click to expand' }));
expect(scrollContainer.scrollTop).toBe(96);
});
it('renders compacting and compacted messages as divider banners', () => { it('renders compacting and compacted messages as divider banners', () => {
const { rerender, container } = render( const { rerender, container } = render(
<AssistantMessage content="Compacting Conversation" /> <AssistantMessage content="Compacting Conversation" />
@@ -133,4 +196,38 @@ describe('AssistantMessage', () => {
expect(screen.getByText('Working on: Writing harmony')).toBeInTheDocument(); expect(screen.getByText('Working on: Writing harmony')).toBeInTheDocument();
expect(screen.queryByText('fallback content')).not.toBeInTheDocument(); expect(screen.queryByText('fallback content')).not.toBeInTheDocument();
}); });
it('renders the add_notes summary instead of the raw tool result text', () => {
render(
<AssistantMessage
content="✅ **add_notes**\n\n └── Successfully created 81 notes: C4..."
toolName="add_notes"
toolSuccess={true}
toolRawResult="Successfully created 81 notes: C4..."
toolResultDisplayContent="Successfully created 81 notes in region **Verse Melody** on track **Lead Vox**, spanning bars 5 to 12."
/>
);
expect(screen.getByText('add_notes')).toBeInTheDocument();
expect(screen.getByText(/└──/)).toBeInTheDocument();
expect(screen.getByText(/Successfully created 81 notes in region/i)).toBeInTheDocument();
expect(screen.getByText('Verse Melody')).toBeInTheDocument();
expect(screen.getByText('Lead Vox')).toBeInTheDocument();
expect(screen.queryByText(/Successfully created 81 notes: C4/)).not.toBeInTheDocument();
});
it('renders generic tool results with the stable shell and raw body by default', () => {
render(
<AssistantMessage
content="✅ **read_music**\n\n └── raw fallback"
toolName="read_music"
toolSuccess={true}
toolRawResult="C D E F"
/>
);
expect(screen.getByText('read_music')).toBeInTheDocument();
expect(screen.getByText(/└──/)).toBeInTheDocument();
expect(screen.getByText('C D E F')).toBeInTheDocument();
});
}); });
+132 -5
View File
@@ -1,8 +1,9 @@
import React, { memo, useEffect, useState } from 'react'; import React, { memo, useEffect, useRef, useState } from 'react';
import ReactMarkdown from 'react-markdown'; import ReactMarkdown from 'react-markdown';
import rehypeKatex from 'rehype-katex'; import rehypeKatex from 'rehype-katex';
import remarkGfm from 'remark-gfm'; import remarkGfm from 'remark-gfm';
import remarkMath from 'remark-math'; import remarkMath from 'remark-math';
import { FaCaretDown, FaCaretUp } from 'react-icons/fa';
import { Prism as SyntaxHighlighter } from 'react-syntax-highlighter'; import { Prism as SyntaxHighlighter } from 'react-syntax-highlighter';
import { vscDarkPlus } from 'react-syntax-highlighter/dist/esm/styles/prism'; import { vscDarkPlus } from 'react-syntax-highlighter/dist/esm/styles/prism';
import type { PerformanceInfo } from '../../agent/llm/StreamingTypes'; import type { PerformanceInfo } from '../../agent/llm/StreamingTypes';
@@ -16,13 +17,109 @@ interface AssistantMessageProps {
performanceInfo?: PerformanceInfo; performanceInfo?: PerformanceInfo;
toolName?: string; toolName?: string;
toolSuccess?: boolean; toolSuccess?: boolean;
toolRawResult?: string;
toolResultDisplayContent?: string;
todoSnapshot?: TodoItem[]; todoSnapshot?: TodoItem[];
isToolCallMessage?: boolean;
} }
// Memoized code component to prevent SyntaxHighlighter re-renders const COLLAPSED_TOOL_CALL_HEIGHT_PX = 200;
// eslint-disable-next-line @typescript-eslint/no-explicit-any const TOOL_CALL_FADE_HEIGHT_PX = 50;
const CodeComponent = memo(({ inline, className, children, ...props }: any) => {
interface MarkdownCodeProps {
inline?: boolean;
className?: string;
children?: React.ReactNode;
}
const ToolCallCodeBlock = memo(({
className,
children,
}: Omit<MarkdownCodeProps, 'inline'>) => {
const containerRef = useRef<HTMLDivElement | null>(null);
const [isExpandable, setIsExpandable] = useState(false);
const [isExpanded, setIsExpanded] = useState(false);
const [expandedHeight, setExpandedHeight] = useState(COLLAPSED_TOOL_CALL_HEIGHT_PX);
const match = /language-(\w+)/.exec(className || ''); const match = /language-(\w+)/.exec(className || '');
const codeText = String(children).replace(/\n$/, '');
useEffect(() => {
const container = containerRef.current;
if (!container) {
return;
}
const measuredHeight = container.scrollHeight;
setExpandedHeight(measuredHeight);
setIsExpandable(measuredHeight > COLLAPSED_TOOL_CALL_HEIGHT_PX);
}, [codeText]);
const handleToggleExpanded = () => {
const scrollContainer = containerRef.current?.closest('.chatbox-messages') as HTMLDivElement | null;
const previousScrollTop = scrollContainer?.scrollTop ?? null;
setIsExpanded((current) => !current);
window.requestAnimationFrame(() => {
if (scrollContainer && previousScrollTop !== null) {
scrollContainer.scrollTop = previousScrollTop;
}
});
};
const maxHeight = isExpanded ? `${expandedHeight}px` : `${COLLAPSED_TOOL_CALL_HEIGHT_PX}px`;
return (
<div
className={`tool-call-code-block${isExpandable ? ' is-expandable' : ''}${isExpanded ? ' is-expanded' : ''}`}
data-testid="tool-call-code-block"
>
<div
ref={containerRef}
className="tool-call-code-block-inner"
style={{ maxHeight }}
>
<SyntaxHighlighter
style={vscDarkPlus}
language={match?.[1]}
PreTag="div"
>
{codeText}
</SyntaxHighlighter>
</div>
{isExpandable && (
<button
type="button"
className="tool-call-code-block-toggle"
onClick={handleToggleExpanded}
>
<span
className="tool-call-code-block-fade"
aria-hidden="true"
style={{ height: `${TOOL_CALL_FADE_HEIGHT_PX}px` }}
/>
<span className="tool-call-code-block-toggle-content">
{isExpanded ? <FaCaretUp aria-hidden="true" /> : <FaCaretDown aria-hidden="true" />}
<span>{isExpanded ? 'Click to collapse' : 'Click to expand'}</span>
{isExpanded ? <FaCaretUp aria-hidden="true" /> : <FaCaretDown aria-hidden="true" />}
</span>
</button>
)}
</div>
);
});
// Memoized code component to prevent SyntaxHighlighter re-renders
const CodeComponent = memo(({ inline, className, children, isToolCallMessage, ...props }: MarkdownCodeProps & { isToolCallMessage: boolean }) => {
const match = /language-(\w+)/.exec(className || '');
if (!inline && match && isToolCallMessage) {
return (
<ToolCallCodeBlock className={className}>
{children}
</ToolCallCodeBlock>
);
}
return !inline && match ? ( return !inline && match ? (
<SyntaxHighlighter <SyntaxHighlighter
style={vscDarkPlus} style={vscDarkPlus}
@@ -70,7 +167,10 @@ const AssistantMessage: React.FC<AssistantMessageProps> = ({
performanceInfo, performanceInfo,
toolName, toolName,
toolSuccess, toolSuccess,
toolRawResult,
toolResultDisplayContent,
todoSnapshot, todoSnapshot,
isToolCallMessage = false,
}) => { }) => {
const prefillTps = formatTps(performanceInfo?.prefillTps); const prefillTps = formatTps(performanceInfo?.prefillTps);
const generationTps = formatTps(performanceInfo?.generationTps); const generationTps = formatTps(performanceInfo?.generationTps);
@@ -82,6 +182,8 @@ const AssistantMessage: React.FC<AssistantMessageProps> = ({
|| content === COMPACTION_DONE_LABEL || content === COMPACTION_DONE_LABEL
|| content === COMPACTION_EMPTY_LABEL; || content === COMPACTION_EMPTY_LABEL;
const isTodoSnapshotCard = toolName === 'update_todo_list' && Array.isArray(todoSnapshot); const isTodoSnapshotCard = toolName === 'update_todo_list' && Array.isArray(todoSnapshot);
const shouldRenderGenericToolResult = Boolean(toolName) && typeof toolSuccess === 'boolean' && !isTodoSnapshotCard;
const genericToolDisplayContent = toolResultDisplayContent ?? toolRawResult ?? content;
useEffect(() => { useEffect(() => {
if (!isThinking) { if (!isThinking) {
@@ -184,12 +286,37 @@ const AssistantMessage: React.FC<AssistantMessageProps> = ({
} }
} }
if (shouldRenderGenericToolResult && toolName) {
return (
<div className="message-tool-result">
<p className="message-tool-result-title">
<span aria-hidden="true">{toolSuccess ? '✅' : '❌'}</span>{' '}
<strong>{toolName}</strong>
</p>
<div className="message-tool-summary">
<span className="message-tool-summary-prefix" aria-hidden="true"> </span>
<div className="message-tool-summary-content">
<ReactMarkdown
remarkPlugins={[remarkGfm, remarkMath]}
rehypePlugins={[rehypeKatex]}
components={{
code: (props) => <CodeComponent {...props} isToolCallMessage={false} />,
}}
>
{genericToolDisplayContent}
</ReactMarkdown>
</div>
</div>
</div>
);
}
return ( return (
<ReactMarkdown <ReactMarkdown
remarkPlugins={[remarkGfm, remarkMath]} remarkPlugins={[remarkGfm, remarkMath]}
rehypePlugins={[rehypeKatex]} rehypePlugins={[rehypeKatex]}
components={{ components={{
code: CodeComponent, code: (props) => <CodeComponent {...props} isToolCallMessage={isToolCallMessage} />,
}} }}
> >
{content} {content}
+108
View File
@@ -8,6 +8,24 @@ vi.mock('../agent/core/AgentCore', () => ({
} }
})); }));
vi.mock('../core/KGCore', () => ({
KGCore: {
instance: vi.fn()
}
}));
vi.mock('../stores/projectStore', () => ({
useProjectStore: {
getState: vi.fn(() => ({
activeRegionId: null,
selectedRegionIds: [],
timeSignature: { numerator: 4, denominator: 4 },
tracks: [],
refreshProjectState: vi.fn(),
})),
},
}));
vi.mock('../utils/chatMessageUtils', () => ({ vi.mock('../utils/chatMessageUtils', () => ({
createStreamingMessage: () => ({ createStreamingMessage: () => ({
id: 'streaming-message', id: 'streaming-message',
@@ -24,6 +42,8 @@ vi.mock('../utils/chatMessageUtils', () => ({
})); }));
import { AgentCore } from '../agent/core/AgentCore'; import { AgentCore } from '../agent/core/AgentCore';
import { KGCore } from '../core/KGCore';
import { KGMidiRegion } from '../core/region/KGMidiRegion';
import { useStreamProcessor } from './useStreamProcessor'; import { useStreamProcessor } from './useStreamProcessor';
import type { ChatMessage } from '../types/projectTypes'; import type { ChatMessage } from '../types/projectTypes';
@@ -215,6 +235,94 @@ describe('useStreamProcessor', () => {
const addedMessages = [...messages.values()]; const addedMessages = [...messages.values()];
expect(addedMessages.some(message => message.content.includes('Calling tool: read_music'))).toBe(true); expect(addedMessages.some(message => message.content.includes('Calling tool: read_music'))).toBe(true);
expect(addedMessages.some(message => message.isToolCallMessage)).toBe(true);
expect(addedMessages.some(message => message.toolName === 'update_todo_list')).toBe(false); expect(addedMessages.some(message => message.toolName === 'update_todo_list')).toBe(false);
}); });
it('attaches add_notes summary metadata for chat-only rendering while preserving raw content', async () => {
const selectedRegion = new KGMidiRegion('region-1', '1', 0, 'Verse Melody');
vi.spyOn(AgentCore, 'instance').mockReturnValue({
getAgentState: () => ({
getTodos: () => [],
}),
processUserInput: async function* () {
yield {
type: 'tool_call',
content: '',
toolCall: {
id: 'add-notes-call-1',
type: 'function',
function: {
name: 'add_notes',
arguments: JSON.stringify({
notes: [
{ pitch: 'C4', start: 16, length: 4 },
{ pitch: 'E4', start: 20, length: 8 },
],
}),
},
},
};
yield {
type: 'tool_result',
content: '',
toolResult: {
name: 'add_notes',
success: true,
result: 'Successfully created 2 notes: C4 (beat 16, length 4), E4 (beat 20, length 8)',
},
};
yield { type: 'done', content: '' };
},
} as unknown as AgentCore);
vi.spyOn(KGCore, 'instance').mockReturnValue({
getCurrentProject: () => ({
getTimeSignature: () => ({ numerator: 4, denominator: 4 }),
getTracks: () => [
{
getId: () => '1',
getName: () => 'Lead',
getRegions: () => [selectedRegion],
},
],
}),
getSelectedItems: () => [selectedRegion],
} as unknown as KGCore);
const messages = new Map<string, ChatMessage>();
const { result } = renderHook(() => useStreamProcessor({
onMessageAdd: (message) => {
messages.set(message.id, message);
},
onMessageUpdate: (messageId, updater) => {
const current = messages.get(messageId);
if (!current) {
throw new Error(`Missing message ${messageId}`);
}
messages.set(messageId, updater(current));
},
onMessageRemove: (messageId) => {
messages.delete(messageId);
},
onProcessingChange: () => undefined,
}));
await act(async () => {
await result.current.processStream('add notes prompt');
});
const addedMessages = [...messages.values()];
const toolCallMessage = addedMessages.find(message => message.isToolCallMessage);
const addNotesMessage = addedMessages.find(message => message.toolName === 'add_notes');
expect(toolCallMessage?.content).toContain('Calling tool: add_notes');
expect(addNotesMessage?.content).toContain('Successfully created 2 notes:');
expect(addNotesMessage?.toolRawResult).toBe('Successfully created 2 notes: C4 (beat 16, length 4), E4 (beat 20, length 8)');
expect(addNotesMessage?.toolResultDisplayContent).toBe(
'Successfully created 2 notes in region **Verse Melody** on track **Lead**, spanning bars 5 to 7.'
);
});
}); });
+163 -2
View File
@@ -1,9 +1,148 @@
import { useState, useCallback } from 'react'; import { useState, useCallback } from 'react';
import { AgentCore } from '../agent/core/AgentCore'; import { AgentCore } from '../agent/core/AgentCore';
import { KGCore } from '../core/KGCore';
import { KGMidiRegion } from '../core/region/KGMidiRegion';
import { createStreamingMessage, createMessage } from '../utils/chatMessageUtils'; import { createStreamingMessage, createMessage } from '../utils/chatMessageUtils';
import { useProjectStore } from '../stores/projectStore';
import type { ChatMessage } from '../types/projectTypes'; import type { ChatMessage } from '../types/projectTypes';
const TODO_TOOL_NAME = 'update_todo_list'; const TODO_TOOL_NAME = 'update_todo_list';
const ADD_NOTES_TOOL_NAME = 'add_notes';
interface PendingToolCall {
name: string;
arguments: Record<string, unknown> | null;
}
interface AddNotesToolArguments {
notes: Array<{
pitch: string;
start: number;
length: number;
velocity?: number;
}>;
region_id?: string;
}
const getBarNumberFromStartBeat = (beat: number, beatsPerBar: number): number => (
Math.floor(beat / beatsPerBar) + 1
);
const getBarNumberFromEndBeat = (beat: number, beatsPerBar: number): number => (
Math.max(1, Math.ceil(beat / beatsPerBar))
);
interface AddNotesSummaryData {
noteCount: number;
regionName: string;
trackName: string;
earliestNoteStartBar: number;
latestNoteEndBar: number;
}
const resolveTargetMidiRegion = (
regionId: string | undefined,
storeState: ReturnType<typeof useProjectStore.getState>,
): { region: KGMidiRegion; trackName: string } | undefined => {
const project = KGCore.instance().getCurrentProject();
const tracks = project.getTracks();
const findById = (candidateRegionId: string): { region: KGMidiRegion; trackName: string } | undefined => {
for (const track of tracks) {
const region = track.getRegions().find(candidate => candidate.getId() === candidateRegionId);
if (region instanceof KGMidiRegion) {
return {
region,
trackName: track.getName(),
};
}
}
return undefined;
};
if (regionId) {
return findById(regionId);
}
if (storeState.activeRegionId) {
const activeRegion = findById(storeState.activeRegionId);
if (activeRegion) {
return activeRegion;
}
}
const selectedRegionId = storeState.selectedRegionIds.at(-1);
if (selectedRegionId) {
const selectedRegion = findById(selectedRegionId);
if (selectedRegion) {
return selectedRegion;
}
}
const selectedItems = KGCore.instance().getSelectedItems();
for (const item of selectedItems) {
if (item instanceof KGMidiRegion) {
const track = tracks.find(candidate => candidate.getId() === item.getTrackId());
return {
region: item,
trackName: track?.getName() ?? `Track ${item.getTrackIndex() + 1}`,
};
}
}
return undefined;
};
const buildAddNotesSummary = (args: Record<string, unknown> | null): AddNotesSummaryData | undefined => {
if (!args) {
return undefined;
}
const typedArgs = args as AddNotesToolArguments;
if (!Array.isArray(typedArgs.notes) || typedArgs.notes.length === 0) {
return undefined;
}
const storeState = useProjectStore.getState();
const project = KGCore.instance().getCurrentProject();
const beatsPerBar = project.getTimeSignature().numerator ?? storeState.timeSignature.numerator;
const targetRegion = resolveTargetMidiRegion(typedArgs.region_id, storeState);
if (!targetRegion) {
return undefined;
}
const earliestNoteStartBeat = Math.min(...typedArgs.notes.map(note => note.start));
const latestNoteEndBeat = Math.max(...typedArgs.notes.map(note => note.start + note.length));
return {
noteCount: typedArgs.notes.length,
regionName: targetRegion.region.getName(),
trackName: targetRegion.trackName,
earliestNoteStartBar: getBarNumberFromStartBeat(earliestNoteStartBeat, beatsPerBar),
latestNoteEndBar: getBarNumberFromEndBeat(latestNoteEndBeat, beatsPerBar),
};
};
const buildToolResultDisplayContent = (
toolName: string,
success: boolean,
rawResult: string,
toolArgs: Record<string, unknown> | null,
): string => {
if (!success) {
return rawResult;
}
if (toolName === ADD_NOTES_TOOL_NAME) {
const summary = buildAddNotesSummary(toolArgs);
if (summary) {
return `Successfully created ${summary.noteCount} ${summary.noteCount === 1 ? 'note' : 'notes'} in region **${summary.regionName}** on track **${summary.trackName}**, spanning bars ${summary.earliestNoteStartBar} to ${summary.latestNoteEndBar}.`;
}
}
return rawResult;
};
interface StreamProcessorOptions { interface StreamProcessorOptions {
onMessageUpdate: (messageId: string, updater: (msg: ChatMessage) => ChatMessage) => void; onMessageUpdate: (messageId: string, updater: (msg: ChatMessage) => ChatMessage) => void;
@@ -35,6 +174,7 @@ export const useStreamProcessor = (options: StreamProcessorOptions): StreamProce
// Track the current streaming message ID (mutable) // Track the current streaming message ID (mutable)
const initialStreamingMsg = createStreamingMessage(); const initialStreamingMsg = createStreamingMessage();
let currentStreamingId = initialStreamingMsg.id; let currentStreamingId = initialStreamingMsg.id;
const pendingToolCalls: PendingToolCall[] = [];
onMessageAdd(initialStreamingMsg); onMessageAdd(initialStreamingMsg);
try { try {
@@ -91,14 +231,29 @@ export const useStreamProcessor = (options: StreamProcessorOptions): StreamProce
try { try {
const args = JSON.parse(chunk.toolCall.function.arguments); const args = JSON.parse(chunk.toolCall.function.arguments);
argsDisplay = JSON.stringify(args, null, 2); argsDisplay = JSON.stringify(args, null, 2);
pendingToolCalls.push({ name: toolName, arguments: args });
} catch { } catch {
argsDisplay = chunk.toolCall.function.arguments; argsDisplay = chunk.toolCall.function.arguments;
pendingToolCalls.push({ name: toolName, arguments: null });
} }
const toolCallMsg = createMessage('assistant', `🔧 **Calling tool: ${toolName}**\n\n\`\`\`json\n${argsDisplay}\n\`\`\``); const toolCallMsg = {
...createMessage('assistant', `🔧 **Calling tool: ${toolName}**\n\n\`\`\`json\n${argsDisplay}\n\`\`\``),
isToolCallMessage: true,
};
onMessageAdd(toolCallMsg); onMessageAdd(toolCallMsg);
} else if (chunk.type === 'tool_result' && chunk.toolResult) { } else if (chunk.type === 'tool_result' && chunk.toolResult) {
// Show tool result in UI // Show tool result in UI
const { name, success, result } = chunk.toolResult; const { name, success, result } = chunk.toolResult;
const pendingToolCallIndex = pendingToolCalls.findIndex(toolCall => toolCall.name === name);
const pendingToolCall = pendingToolCallIndex >= 0
? pendingToolCalls.splice(pendingToolCallIndex, 1)[0]
: undefined;
const toolResultDisplayContent = buildToolResultDisplayContent(
name,
success,
result,
pendingToolCall?.arguments ?? null,
);
const toolResultMsg = name === TODO_TOOL_NAME const toolResultMsg = name === TODO_TOOL_NAME
? { ? {
...createMessage('assistant', result), ...createMessage('assistant', result),
@@ -106,7 +261,13 @@ export const useStreamProcessor = (options: StreamProcessorOptions): StreamProce
toolSuccess: success, toolSuccess: success,
todoSnapshot: AgentCore.instance().getAgentState().getTodos().map(todo => ({ ...todo })), todoSnapshot: AgentCore.instance().getAgentState().getTodos().map(todo => ({ ...todo })),
} }
: createMessage('assistant', `${success ? '✅' : '❌'} **${name}**\n\n └── ${result}`); : {
...createMessage('assistant', `${success ? '✅' : '❌'} **${name}**\n\n └── ${result}`),
toolName: name,
toolSuccess: success,
toolRawResult: result,
toolResultDisplayContent,
};
onMessageAdd(toolResultMsg); onMessageAdd(toolResultMsg);
// Reset for the next LLM turn in the agentic loop // Reset for the next LLM turn in the agentic loop
+3
View File
@@ -16,7 +16,10 @@ export interface ChatMessage {
performanceInfo?: PerformanceInfo; performanceInfo?: PerformanceInfo;
toolName?: string; toolName?: string;
toolSuccess?: boolean; toolSuccess?: boolean;
toolRawResult?: string;
toolResultDisplayContent?: string;
todoSnapshot?: TodoItem[]; todoSnapshot?: TodoItem[];
isToolCallMessage?: boolean;
} }
/** /**