From 7ee4a7458ea26a5958921cf5d6c2d170da8def4c Mon Sep 17 00:00:00 2001 From: Xiaohan-Tian <157918347+Xiaohan-Tian@users.noreply.github.com> Date: Sat, 23 May 2026 23:39:52 -0700 Subject: [PATCH] fix: update default master volume to 1.0 --- src/constants/coreConstants.ts | 2 +- src/test/utils/mock-data.ts | 2 +- src/test/utils/setup-integration-tests.ts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/constants/coreConstants.ts b/src/constants/coreConstants.ts index a1d36b4..b755357 100644 --- a/src/constants/coreConstants.ts +++ b/src/constants/coreConstants.ts @@ -62,7 +62,7 @@ export const KEY_SIGNATURE_MAP = { // }; export const AUDIO_INTERFACE_CONSTANTS = { - DEFAULT_MASTER_VOLUME: 0.8, + DEFAULT_MASTER_VOLUME: 1.0, DEFAULT_TRACK_VOLUME: 0, // 0 dB (unity gain) MIN_TRACK_VOLUME_DB: -60, // practical floor; displayed as −∞ MAX_TRACK_VOLUME_DB: 12, diff --git a/src/test/utils/mock-data.ts b/src/test/utils/mock-data.ts index 9024bcf..a8427fe 100644 --- a/src/test/utils/mock-data.ts +++ b/src/test/utils/mock-data.ts @@ -120,7 +120,7 @@ export const createMockMidiTrack = (overrides: Partial<{ name: 'Test Track', id: 0, instrument: 'acoustic_grand_piano' as const, - volume: 0.8, + volume: 0, ...overrides }; diff --git a/src/test/utils/setup-integration-tests.ts b/src/test/utils/setup-integration-tests.ts index 5a60f65..3e860c1 100644 --- a/src/test/utils/setup-integration-tests.ts +++ b/src/test/utils/setup-integration-tests.ts @@ -81,7 +81,7 @@ export const createMockTrack = (name = 'Test Track') => { id: `track-${Date.now()}`, name, instrument: 'acoustic_grand_piano', - volume: 0.8, + volume: 0, regions: [], }; }; @@ -104,4 +104,4 @@ export const createMockNote = (pitch = 60, startBeat = 0, endBeat = 1) => { endBeat, velocity: 100, }; -}; \ No newline at end of file +};