Gap 12: soundfont render qua native bridge — render_soundfont_offline (FluidSynth C API) thay pyfluidsynth khi thiếu lib; render_engine soundfont branch fallback bridge (test_64, 176 passed)

2026-08-23 08:52:57 +07:00
parent 6b2c9a039b
commit 2b5f396133
3 changed files with 186 additions and 58 deletions
@@ -126,6 +126,65 @@ def _preset_b64(preset_id, preset_path, preset_data_b64) -> str:
    return ""


+def _run_notes_job(job: dict, label: str) -> tuple:
+    """Chạy job MIDI render qua native_bridge --render → (out_path, duration_sec).
+
+    Dùng chung cho VSTi (render_offline) + SoundFont (render_soundfont_offline).
+    Lỗi → HTTPException (501 thiếu bridge, 500 lỗi render — file rác bị xóa).
+    """
+    exe = find_bridge_exe()
+    if not exe:
+        raise HTTPException(
+            status_code=501,
+            detail="native_bridge không khả dụng — đặt SF_BRIDGE_PATH hoặc cài daw_vst_bridge",
+        )
+    os.makedirs(settings.PROCESSED_DIR, exist_ok=True)
+    out_path = os.path.join(settings.PROCESSED_DIR, f"preview_{uuid.uuid4().hex[:10]}.wav")
+    job_path = out_path + ".job.json"
+    try:
+        with open(job_path, "w", encoding="utf-8") as fh:
+            json.dump(job, fh)
+        r = subprocess.run([exe, "--render", job_path, "--out", out_path],
+                           capture_output=True, text=True, timeout=120,
+                           creationflags=subprocess.CREATE_NO_WINDOW if os.name == "nt" else 0)
+        log = ((r.stdout or "") + (r.stderr or "")).strip()
+        if r.returncode != 0 or not os.path.isfile(out_path):
+            if os.path.exists(out_path):
+                try:
+                    os.remove(out_path)
+                except Exception:
+                    pass
+            if r.returncode == 2:
+                raise HTTPException(status_code=500,
+                                    detail=f"Bridge không load được plugin {label}. {log[-500:]}")
+            raise HTTPException(status_code=500,
+                                detail=f"Render thất bại (rc={r.returncode}). {log[-500:]}")
+        normalize_peak_file(out_path)
+        return out_path, sf.info(out_path).frames / float(job.get("sample_rate", 44100))
+    except HTTPException:
+        raise
+    except subprocess.TimeoutExpired:
+        if os.path.exists(out_path):
+            try:
+                os.remove(out_path)
+            except Exception:
+                pass
+        raise HTTPException(status_code=500, detail="Render quá lâu (timeout 120s)")
+    except Exception as e:
+        if os.path.exists(out_path):
+            try:
+                os.remove(out_path)
+            except Exception:
+                pass
+        raise HTTPException(status_code=500, detail=f"Render thất bại: {e}")
+    finally:
+        if os.path.exists(job_path):
+            try:
+                os.remove(job_path)
+            except Exception:
+                pass
+
+
 def render_offline(instrument_id, notes, bpm, sample_rate, preset_id=None,
                   preset_path=None, preset_data_b64=None,
                   soundfont_bank=None, soundfont_program=None) -> tuple:
@@ -141,12 +200,6 @@ def render_offline(instrument_id, notes, bpm, sample_rate, preset_id=None,
            detail=f"Không tìm thấy VSTi: {instrument_id} — chưa scan thấy plugin này. "
                   "Kiểm tra Plugins Manager → Scan.",
        )
-    exe = find_bridge_exe()
-    if not exe:
-        raise HTTPException(
-            status_code=501,
-            detail="native_bridge không khả dụng — đặt SF_BRIDGE_PATH hoặc cài daw_vst_bridge",
-        )
    job = {
        "instrument_type": itype,
        "plugin_path": path,
@@ -169,51 +222,31 @@ def render_offline(instrument_id, notes, bpm, sample_rate, preset_id=None,
        job["soundfont_bank"] = int(soundfont_bank) & 0x7F
    if soundfont_program is not None:
        job["soundfont_program"] = int(soundfont_program) & 0x7F
-    os.makedirs(settings.PROCESSED_DIR, exist_ok=True)
-    out_path = os.path.join(settings.PROCESSED_DIR, f"preview_{uuid.uuid4().hex[:10]}.wav")
-    job_path = out_path + ".job.json"
-    try:
-        with open(job_path, "w", encoding="utf-8") as fh:
-            json.dump(job, fh)
-        r = subprocess.run([exe, "--render", job_path, "--out", out_path],
-                           capture_output=True, text=True, timeout=120,
-                           creationflags=subprocess.CREATE_NO_WINDOW if os.name == "nt" else 0)
-        log = ((r.stdout or "") + (r.stderr or "")).strip()
-        if r.returncode != 0 or not os.path.isfile(out_path):
-            if os.path.exists(out_path):
-                try:
-                    os.remove(out_path)
-                except Exception:
-                    pass
-            if r.returncode == 2:
-                raise HTTPException(status_code=500,
-                                    detail=f"Bridge không load được plugin {instrument_id}. {log[-500:]}")
-            raise HTTPException(status_code=500,
-                                detail=f"Render thất bại (rc={r.returncode}). {log[-500:]}")
-        normalize_peak_file(out_path)
-        return out_path, sf.info(out_path).frames / float(sample_rate)
-    except HTTPException:
-        raise
-    except subprocess.TimeoutExpired:
-        if os.path.exists(out_path):
-            try:
-                os.remove(out_path)
-            except Exception:
-                pass
-        raise HTTPException(status_code=500, detail="Render quá lâu (timeout 120s)")
-    except Exception as e:
-        if os.path.exists(out_path):
-            try:
-                os.remove(out_path)
-            except Exception:
-                pass
-        raise HTTPException(status_code=500, detail=f"Render thất bại: {e}")
-    finally:
-        if os.path.exists(job_path):
-            try:
-                os.remove(job_path)
-            except Exception:
-                pass
+    return _run_notes_job(job, instrument_id)
+
+
+def render_soundfont_offline(sf_path, notes, bpm, sample_rate, bank=0, program=0) -> tuple:
+    """Render MIDI notes bằng SoundFont (.sf2/.sf3) qua native_bridge --render.
+
+    Thay pyfluidsynth khi thiếu FluidSynth lib: bridge nhúng FluidSynth C API
+    (NativeInstrumentEngine.cpp, InstrumentType::SOUNDFONT_SF2_SF3) — cùng job
+    shape với render_offline nhưng instrument_type=2 + plugin_path là file SF2.
+    Lỗi → HTTPException (501 thiếu bridge, 500 lỗi render)."""
+    job = {
+        "instrument_type": 2,
+        "plugin_path": os.fspath(sf_path),
+        "sample_rate": int(sample_rate),
+        "bpm": float(bpm),
+        "soundfont_bank": int(bank) & 0x7F,
+        "soundfont_program": int(program) & 0x7F,
+        "notes": [{
+            "pitch": int(n.get("pitch", 60)),
+            "velocity": float(n.get("velocity", 0.8)),  # bridge job: float 0..1 (RenderJob.cpp *127)
+            "start_beat": float(n.get("start_beat", 0)),
+            "duration_beats": float(n.get("duration_beats", 1)),
+        } for n in notes],
+    }
+    return _run_notes_job(job, os.fspath(sf_path))


 def render_fx_chain(input_wav, fx_chain, sample_rate, out_path=None):