3dtours/SonicForgeStudio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIX: sửa lỗi MIDI item với fx mastering tồn tại và không qua Carla

Browse Source
This commit is contained in:
locpham
2026-08-10 17:48:38 +07:00
parent a1dc074e35
commit 67ad2b8e4b
3 changed files with 83 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/static/js/app.jsx
+35 -4
View File
@@ -15283,9 +15283,14 @@ const App = () => {
setLastMidiNote({ pitch, velocity: scaledVel, length: 0, time: Date.now() });
activeMidiPitchesRef.current.add(pitch);
setActiveMidiPitches(new Set(activeMidiPitchesRef.current));
// Route MIDI input to ALL armed tracks on their dedicated channels
// Do NOT use raw MIDI hardware channel (msg.data[0] & 0x0F)
if (window.SonicSF) {
// MIDI Keyboard → Mastering FX Chain (main out): đồng bộ routing
// mastering + SF NGAY trước khi phát — âm MIDI keyboard hardware
// PHẢI qua mastering FX khi chain đang bật (giống keybed; trước
// đây chỉ keybed ảo gọi __ensureMasteringRouting).
try { if (window.__ensureMasteringRouting) window.__ensureMasteringRouting(); } catch (er) {}
// Route MIDI input to ALL armed tracks on their dedicated channels
// Do NOT use raw MIDI hardware channel (msg.data[0] & 0x0F)
if (window.SonicSF) {
var allTracks = activeTracksRef.current || [];
var arSubs = subTabsRef && subTabsRef.current ? subTabsRef.current.filter(function(s) { return s.type === 'PIANO_ROLL' && s.isArmed; }) : [];
var armedTracks = allTracks.filter(function(t) { return t.isArmed; });
@@ -15305,6 +15310,11 @@ const App = () => {
heldMidiNotesRef.current[as.trackId] = (heldMidiNotesRef.current[as.trackId] || 0) + 1;
} catch (err) { }
window.SonicSF.playNote(pitch, scaledVel, 60000, undefined, asProg, null, asCh, asSe);
// MIDI Keyboard → Carla bridge (piano roll sub-tab ARM):
// track VSTi của sub-tab phát VSTi realtime giống keybed.
if (window.SonicCarlaMidi && window.SonicCarlaMidi.shouldRoute(asSe, true)) {
try { window.SonicCarlaMidi.noteOn(asCh, pitch, scaledVel); } catch (e) {}
}
});
}
// Route to ALL armed tracks (not just the first one)
@@ -15321,7 +15331,14 @@ const App = () => {
heldMidiNotesRef.current[at.id] = (heldMidiNotesRef.current[at.id] || 0) + 1;
} catch (err) { }
window.SonicSF.playNote(pitch, scaledVel, 60000, undefined, atProg, atDest, atCh, atSe);
});
// MIDI Keyboard → Carla bridge (track VSTi + ARM + Carla
// local): phát VSTi realtime — giống hệt keybed ảo. Trước
// đây chỉ keybed gọi SonicCarlaMidi; keyboard hardware bị
// bỏ sót → track VSTi không kêu khi bấm đàn thật.
if (window.SonicCarlaMidi && window.SonicCarlaMidi.shouldRoute(atSe, at.isArmed)) {
try { window.SonicCarlaMidi.noteOn(atCh, pitch, scaledVel); } catch (e) {}
}
});
}
} else if (cmd === 0x8 || (cmd === 0x9 && rawVel === 0)) {
activeMidiPitchesRef.current.delete(pitch);
@@ -15343,6 +15360,11 @@ const App = () => {
if (!st.synth_engine && st.midiChannel === undefined) return;
var stCh = assignTrackMidiChannel(st, stopTracks);
window.SonicSF.stopNote(stCh, pitch);
// MIDI Keyboard → Carla bridge: note-off khi thả phím — tránh
// kẹt âm VSTi (giống keybed ảo).
if (window.SonicCarlaMidi && window.SonicCarlaMidi.shouldRoute(st.synth_engine, st.isArmed)) {
try { window.SonicCarlaMidi.noteOff(stCh, pitch); } catch (e) {}
}
// Giảm counter note đang giữ — hết note → VU được phép decay/tắt
// (tick sẽ thấy counter = 0 và không còn giữ peak nữa)
try {
@@ -24686,6 +24708,15 @@ const App = () => {
try {
toggleMasteringOnMaster(!!(masteringSettings && masteringSettings.masterConnected), !!(masteringSettings && masteringSettings.isBypassed));
} catch (e) { console.warn('offline mastering toggle error:', e); }
// Main out volume (master fader) áp vào offline bus — file export phải
// đúng độ lớn nghe được (flow: ... → Mastering FX Chain → Main out).
// Trước đây offline masterBus.output luôn = 1.0 → export sai volume.
try {
if (masterBus && masterBus.output) {
const mv = (typeof masterVolume === 'number' && isFinite(masterVolume)) ? masterVolume : 0;
masterBus.output.gain.setValueAtTime(mv <= -50 ? 0 : Math.pow(10, mv / 20), 0);
}
} catch (e) { console.warn('offline main-out volume error:', e); }
activeTracks.forEach(t => {
const node = buildOfflineTrackNode(t, offlineCtx, offlineNodes);
if (!node) return;