3dtours/SonicForgeStudio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

revert: playhead fixes cause cannot play on MAIN/SECTION-TAB

Browse Source 
Revert two changes from 5d31563:
1. Explicit requestAnimationFrame in handlePlayPause (redundant,
   useEffect already handles RAF start after setIsPlaying)
2. setCurrentTime(0) in handleEditSectionInTab (resets global
   currentTime, interferes with MAIN session position)
This commit is contained in:
3dtours
2026-07-28 09:22:44 +07:00
parent 5d31563df6
commit ea40f0c540
3 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/static/js/app.jsx
-2
View File
@@ -8525,7 +8525,6 @@ const App = () => {
})); }));
setSessionTabs(prev => [...prev, { id: tabId, name: tabName, sectionId: sectionId, tracks: clonedTracks, color: section.color || null }]); setSessionTabs(prev => [...prev, { id: tabId, name: tabName, sectionId: sectionId, tracks: clonedTracks, color: section.color || null }]);
setActiveTab(tabId); setActiveTab(tabId);
setCurrentTime(0);
}; };
// ── Sub Tab: apply effects & merge back (LOOP_EDITOR_2.md §1.2) ── // ── Sub Tab: apply effects & merge back (LOOP_EDITOR_2.md §1.2) ──
@@ -10615,7 +10614,6 @@ const App = () => {
startAudioTimeRef.current = context.currentTime; startAudioTimeRef.current = context.currentTime;
startTrackPlayback(currentTime); startTrackPlayback(currentTime);
setIsPlaying(true); setIsPlaying(true);
animationFrameIdRef.current = requestAnimationFrame(updatePlayhead);
} }
}; };
handlePlayPauseRef.current = handlePlayPause; handlePlayPauseRef.current = handlePlayPause;
app/static/js/app.precompiled.js
+2 -2
View File
File diff suppressed because one or more lines are too long
wiki.md
+3 -3
View File
@@ -539,10 +539,10 @@
- **Ghi chú/Test (nếu có):** `npm run build` pass. Ctrl+Click+Drag section/MIDI item → copy đến vị trí mới, item không bị selected. - **Ghi chú/Test (nếu có):** `npm run build` pass. Ctrl+Click+Drag section/MIDI item → copy đến vị trí mới, item không bị selected.
--- ---
### [2026-07-28 09:17] Task: Playhead SECTION-TAB di chuyển dù không có items ### [2026-07-28 09:21] Task: Revert fix playhead — gây lỗi không play được
- **Tóm tắt thay đổi:** Thêm `requestAnimationFrame(updatePlayhead)` sau `setIsPlaying(true)` trong `handlePlayPause` để đảm bảo RAF luôn chạy. Thêm `setCurrentTime(0)` trong `handleEditSectionInTab` để reset playhead về 0 khi mở section tab. Trước đây playhead không di chuyển vì effect useEffect dependency chưa kịp fire hoặc `currentTime` ở vị trí ngoài section timeline. - **Tóm tắt thay đổi:** Revert 2 changes từ 5d31563: (1) xoá `requestAnimationFrame(updatePlayhead)` thừa trong `handlePlayPause` (effect đã xử lý). (2) xoá `setCurrentTime(0)` trong `handleEditSectionInTab` (gây reset currentTime global). Giữ nguyên các fix instrument isolation + program default.
- **Các file ảnh hưởng:** `app/static/js/app.jsx`, `app/static/js/app.precompiled.js` - **Các file ảnh hưởng:** `app/static/js/app.jsx`, `app/static/js/app.precompiled.js`
- **Ghi chú/Test (nếu có):** `npm run build` pass. Mở SECTION-TAB → Play → playhead di chuyển từ 0 đến maxDuration. - **Ghi chú/Test (nếu có):** `npm run build` pass. Cần kiểm tra Play trên MAIN và SECTION-TAB.
--- ---
### [2026-07-28 09:40] Task: Cả main + section MIDI playback không default program 0 ### [2026-07-28 09:40] Task: Cả main + section MIDI playback không default program 0