3dtours/SonicForgeStudio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,201 Commits 6 Branches 0 Tags
c32c77e4f4cbc7410933cee6c71ba06cf415d137
Commit Graph

968 Commits

Author SHA1 Message Date
3dtours c32c77e4f4 fix(ui): master chain panel - xoa toolbar Delta Listen, GUI VST mo mac dinh spawn fresh moi lan mo panel, busy spinner + banner loi + nut Thu lai khi spawn GUI cham/fail 2026-09-02 20:32:20 +07:00
3dtours 8e4fed5f05 fix(api): /fx-gui/close dong TAT CA bridge trung plugin (khong chi proc dau) 2026-09-02 12:41:16 +07:00
3dtours 33c5cc290f fix(api,ui): chan double-spawn GUI embed master chain - register bridge ngay sau Popen + inflight guard + frontend busy ref (crash 0xc0000005 2 instance Ozone) 2026-09-02 12:34:46 +07:00
3dtours d3094a3ba5 fix(ui): add VST FX vao master chain tu dong mo GUI embed 
MasteringModal co 2 duong add: addMasterVst (goi openMasterVstGui, ham
chet khong ai dung) va addVstToChain (picker dung, chi them vao chain
khong mo GUI) -> user phai bam vao slot moi thay GUI. Gop: addVstToChain
goi openMasterVstGui ngay sau khi them slot.

Verified: engine-from-source serve bundle co fix; app installed (installer
rebuilt -Frontend -Tauri): Ozone GUI OPEN 11.3s, frames 10/10 jpeg, spawn.log
sach 0x7E/Fatal.
 2026-09-02 10:01:48 +07:00
3dtours d068927694 fix(bridge): Ozone FX GUI embed crash license check — sleep truoc attach + retry 5 spawn 
Root cause (minidump x3, cung offset iZOzone11Core.dll+0x18f6b92): crash
deterministic 1 instruction - memcmp std::string [rdi+0x100] vs "iLok"
trong license check, doc heap ptr garbage (use-after-free/corrupt trong
iZotope Product Engine license path, flaky theo timing).

Fixes:
- RenderFxJob.cpp: fxGuiLoadAttach giu retry 4 attempt moi instance moi
  (SEH-guarded dispose); them Sleep(2s) giua load va attach cho plugin
  iZotope/Ozone - Product Engine service het race, attempt 1 open ngay
  (E2E: 60-70s -> 10-22s, 8/8 run OK).
- plugins.py: _spawn_fx_gui_embed process-level respawn 3->5 lan + delay
  2s giua respawn (service can thoi gian hoi phuc sau crash); di chuyen
  BELOW_NORMAL/CREATE_NO_WINDOW sang _fx_gui_creationflags(); gui stdout
  bridge qua thread de khong block event loop (asyncio.to_thread).
- main_fx.cpp: FxCrashDumpHandler log MOI exception (khong chi lan dau),
  minidump van 1 lan/process.

Verified: E2E engine-from-source 8/8 run Ozone embed OK; app installed
(thu cai moi installer NSIS): OPEN 49.5s, frames 10/10 jpeg, spawn.log
khong con 0x7E/Fatal Error.
 2026-09-02 09:40:17 +07:00
3dtours 5b90bd43b5 bump sf-fx-realtime cache-bust version 2026-09-01 22:49:30 +07:00
3dtours be5ecf0a48 fix(ui): Plugin Manager Scan circular JSON — onClick pas synthetic event lam dirsOverride (JSON.stringify event circular) 2026-09-01 21:47:52 +07:00
3dtours 2c4d6c358b V45.39: fix SERVER OFFLINE lau + UI load cham - engine ghi port file (engine_port.txt), UI bootstrap doc port engine cua chinh no (get_engine_port) + timeout/retry 60s, health poll self-heal reload, khong taskkill /IM daw_engine (giet engine instance khac), /api/v1/plugins/available chay scan trong threadpool (khong chan event loop -> /health het timeout) 2026-09-01 16:45:06 +07:00
3dtours c1b73db971 Merge main (V45.1-32 fixes: ReferenceError guard, crackle/solo/seek fixes) vao standalone-shm-bridge (giu FILL 96) 2026-09-01 16:03:28 +07:00
locpham a8082b27c4 V45.33: fix Plugin Manager VSTi liệt kê nhầm VST FX (Ozone Pro/Tonal Balance Control Pro) làm instrument - /available chặn entry UNKNOWN theo tên (bridge timeout introspect VST3) + _norm_path_stem 2026-09-01 10:37:19 +07:00
locpham 4713f8a8a1 V45.33: fix Plugin Manager VSTi liệt kê nhầm VST FX (Ozone Pro/Tonal Balance Control Pro) làm instrument - /available chặn entry UNKNOWN theo tên (bridge timeout introspect VST3) + _norm_path_stem 2026-09-01 10:37:12 +07:00
admin 5f8844637e V45.32: fix (1) latency preview MIDI keyboard - flush ring bridge sink (bridgeAudioWorklet _MAX 32 ~170ms audio cu render truoc) tai idle->active live note-on trong __clearMasterFxQueue (cung dieu kien V45.26: _liveHeldCount===0 && im lang >500ms) de note moi nghe ngay; guard _timelinePlaying (khong flush khi timeline dang play); (2) crackle VST2 tremolo/loop - overrun crossfade tich luy moi block drop cong 256 mau cap 1024 (~21ms) thay vi co dinh 64 mau (1.3ms qua ngan -> blip/wow khi drop loat block o chord nhieu voice) (tai lap tu V45.28, giu ring 32 de latency thap). v=202608311858 2026-08-31 19:00:24 +07:00
admin 21cc8421a5 V45.31: REVERT V45.28 (4ed1de6) ve dung trang thai b64343a (V45.27) de kiem tra latency cao - ring worklet 32 block (~170ms), worklet URL v=202608311809, bo overrun crossfade tich luy 256/cap1024 cua V45.28. v=202608311809 2026-08-31 18:48:08 +07:00
admin 833f3bd158 V45.30: REVERT V45.29 (a069773) - V45.29 ring worklet 80 (~426ms) gay latency cao khi preview midi keyboard (ring luon day, do tre = dung ring cap) va crackle khi Chord VST2; quay ve V45.28 (4ed1de6): ring 48 (~256ms), worklet URL v=202608311820, bo log worklet_stats dinh ky. v=202608311820 2026-08-31 18:44:12 +07:00
admin a069773d4a V45.29: fix wobble preview VST2 chord van con sau V45.28 - ring worklet bridgeAudioWorklet 48->80 block (~426ms) phu stall render loop C++ toi ~361ms do tu log (fxrt_bridge loopMax=361ms, fxrt_pump pump_gap 362ms, longtask d=346): ring 48 (256ms) van khong du -> underrun lap lai fade ve 0 = wobble; them worklet_stats log dinh ky moi ~2s vao dbg.log (preview_diag chi fire keybed/vkb, duong preview khac khong log ws= duoc) de xac minh ov/un sau fix. v=202608311832 2026-08-31 18:32:37 +07:00
admin 4ed1de638d V45.28: fix wobble preview VST2 loop/tremolo khi nhan chord - ring worklet bridgeAudioWorklet 32->48 block (~256ms) hap thu stall render loop C++ khi chord nhieu voice (stall >170ms -> underrun lap lai fade ve 0 nghe nhu wobble; 16->32 V45.27 da dung crackle, 32 chua du cho chord); overrun crossfade tich luy moi block drop cong 256 mau cap 1024 (~21ms) thay vi co dinh 64 mau (1.3ms qua ngan -> blip/wow khi drop loat block o chord nhieu voice). v=202608311820 2026-08-31 18:20:53 +07:00
admin b64343aac6 V45.27: fix (1) PR tab preview cam khi sub-tab PR khong ARM - ARM MAIN/SECTION cuc bo, khong leak sang PR (3 nhanh: vkbNoteOn prArmedIds + attachMidiHandler bridge bPrArmed + SonicSF arSubs them && isArmed); (2) crackle preview VST2 instrument loop/tremolo - ring worklet bridgeAudioWorklet 16->32 block (~170ms) hap thu stall render loop C++ khi instrument xu li loop/tremolo nang CPU (8->16 truoc da dung tremolo, 16 chua du); them stats overrun/underrun tu worklet -> getDiag/preview_diag (ws=ov/un) de xac minh con crackle khong. v=202608311809 2026-08-31 18:10:47 +07:00
admin 72ae2c8a9a V45.26: fix wobble/crackle khi preview MIDI keyboard nhan (1/8 lien tuc) o MAIN/SECTION/PR tab. Root cause: unifiedMidiRouter.pushEvent clear master FX outQueue (__clearMasterFxQueue, V31 fix lag idle backlog ~341ms) tren MOI live NOTE_ON -> rapid notes: moi note wipe queue dang chua tail note truoc + resume fade-in 43ms -> cat tail (crackle) + fade nhap nhay (wobble). Fix: chi clear khi that su idle->active (khong con note dang giu VA im lang >500ms) — dem _liveHeldCount + _lastLiveEventAt; note dang ngan / chuoi note nhanh giu queue. Timeline (live=false) khong doi. v=202608311756 2026-08-31 17:56:17 +07:00
admin fbefa7e864 V45.25: fix ARM leak trong PR tab - preview chi track dang edit. Root cause: vkbNoteOn + attachMidiHandler (bridge bPrArmed va SonicSF arSubs) gom ARM tu TAT CA sub-tab PR (forEach s.isArmed) + track MAIN isArmed -> ARM track 1 leak sang PR tab track 2 (khong ARM) van nghe nhac cu track 1. Fix: trong PIANO_ROLL tab, target = duy nhat sub-tab PR dang active (activeTabRef), bat ke isArmed; MAIN/SECTION giu nguyen (ARM moi, khong ARM -> cam + toast). v=202608311739 2026-08-31 17:39:40 +07:00
admin cdf71078f8 V45.24: dao y/c - solo/mute CHI cuc bo MAIN/SECTION, PIANO ROLL TAB KHONG bi cam. REVERT V45.23 (4 gate computeTrackAudibleGain o preview) + lam PR doc lap: (1) scheduleMidiNoteDispatch them param prNote=true cho 6 nhanh PR (play, ghost, click, draw, brush, wheel) -> bo qua solo_guard + goi ensureTrackPrAudible (CC7=vol theo volumeDb bo qua mute/solo + setTrackNodeGain) tai thoi diem fire; (2) preview keybed vkbNoteOn + hardware attachMidiHandler (bridge + SonicSF fallback) khi _isPrTabNow goi ensureTrackPrAudible de channel khong con bi CC7=0 tu toggle MAIN; (3) applyAllTrackMuteSolo + sync useEffect bo qua gain=0/CC7=0/kill note khi track co sub-tab PR dang PLAY. Timeline MAIN giu solo_guard. v=202608311725 2026-08-31 17:26:08 +07:00
admin 6cd4eb423a V45.23: fix Bug 4 (solo/mute khong tac dung o PIANO ROLL tab) - preview MIDI (keybed vkbNoteOn + hardware attachMidiHandler NOTE_ON bridge/SonicSF fallback) bo qua trang thai mute/solo cua MAIN/SECTION context: track muted hoac solo-out van phat am khi bam phim o PR tab. Them gate computeTrackAudibleGain vao 4 nhanh preview (bTracks, arSubs, armedTracks, vkb targets) - dung semantics nhu scheduleMidiNoteDispatch solo_guard (timeline da dung tu V45.21). vkbNoteOff/note-off bridge KHONG gate (phai kill note dang giu khi mute giua chuong). marker solo_guard block midi ch= p= cho dbg. v=202608311716 2026-08-31 17:16:49 +07:00
admin 2fe78ddd1b V45.22: fix Bug 3 (wobble loop wrap) - wrap restart skipRouting nhu seekPlaybackTo/applyPlayheadDirect: updateSfRouting (AudioRoutingEngine.connect/ disconnect bridge sink + setOutputDestination) chay o MOI wrap trong luc isPlayingRef=false -> stall main thread 122-161ms (pump_gap) > KEEP 16 (~85ms) -> outQueue can -> underrun -> wobble beat 0:0 + playhead desync. skipRouting bo routing khoi critical path wrap -> stall ve duoi KEEP -> het underrun. Them instrument: stop_start log stack caller (xac nhan mystery stop = user Space/Stop, khong phai code) + wrap_timing stop=/start= phan tach stall. v=202608311708 2026-08-31 17:09:28 +07:00
admin 7572d339de V45.21: fix Bug 1 (seek delay - seek branch resumeFill=8 thay vi RESUME_FILL 24 ~128ms -> 43ms nhu wrap V45.4; applyPlayheadDirect stopAllPlayback(false,true) skipRouting nhu seekPlaybackTo) + Bug 2 (attachMidiHandler guard _isPrTabNow nhu vkbNoteOn V45.19 - ARM piano roll khong leak ra MAIN/SESSION) v=202608311642 2026-08-31 16:43:32 +07:00
admin 75b1512779 V45.20: fix Bug 6 (piano roll trang - bo subTabsRef/activeTabRef ngoai scope trong renderKeybed -> const _kbSilent=false; renderKeybed chi chay o PR tab nen luon false) + Bug 1 debug (them pitch vao log midi_push) v=202608311305 2026-08-31 13:04:00 +07:00
admin 36f2cf79b1 V45.19: fix Bug 1b (seek#2 + wrap freeze) + Bug 2 (ARM scope theo active tab) v=202608311242 
- Bug 1b: worklet clear_queue nho clearMode; dbgPlayFirst post fx_seek_first khi
  mode=seek -> main snap khong can guard 50ms (seek resume nhanh ~43ms < 50ms).
- Bug 1b: loop wrap KHONG freeze playhead nua (chi re-anchor processed) -> het
  playhead dung ~1.5s sau wrap (truoc day freeze 1500ms fail-safe).
- Bug 2: vkbNoteOn chi gom ARM piano roll khi DANG o PIANO_ROLL tab; MAIN/SECTION
  khong ARM -> targets rong -> preview cam. renderKeybed silent flag tuong tu.
- DIAG: preview_diag them trg/prTab (vkb) + sl (keybed).
 2026-08-31 12:43:08 +07:00
admin 8a6a79c757 V45.18: fix seek khi play master FX active - clear_queue mode 'seek' (wipe queue cu + resume nhanh 8 block ~43ms thay vi FILL 24 ~128ms) het am tre 1 beat; DIAG preview_diag src=keybed cho Bug 2 ARM piano roll v=202608311222 2026-08-31 12:25:01 +07:00
admin 8ccf7e4b14 V45.17: fix seek khi play master FX active - set startOffsetTimeRef + __fxRtPlayheadFreeze NGAY tai click (het 50ms dau playhead chay theo processed anchor cu truoc khi dung) v=202608311151 2026-08-31 11:52:23 +07:00
admin 80b8c3e034 V45.16: freeze playhead khi seek master FX active (het playhead chay truoc am ~128ms) v=202608311143 2026-08-31 11:43:21 +07:00
admin 39f00c3c0b V45.15: fix ARM piano roll khong am - gop subTab isArmed (PIANO_ROLL) vao 2 path gui note (midi_push bridge branch + vkbNoteOn) - preview note toi track dang edit du track main khong ARM v=202608311122 2026-08-31 11:23:34 +07:00
admin 752db690b3 V45.14: diag preview_audio - dem bridge-audio frames 500ms sau note-on (tach engine render vs JS routing) v=202608311112 2026-08-31 11:11:47 +07:00
admin ad71ac1168 V45.13: diag Bug 3/4 preview khong am - preview_diag tai vkbNoteOn (routing state, BridgeAudioNode.getDiag, masterBus, fxRt, arm/tab) + sf_route tai updateSfRouting (nhanh PR_CONNECT/SINGLE_CONNECT/MASTER_FALLBACK) v=202608311101 2026-08-31 11:05:13 +07:00
admin 845823a9df V45.12: fix SF preset wrong sau reopen (race C++ restore async ghi de program JS vua gui) - retry FORCE CC0/CC32/PROGRAM sau 1.5s/4s/8s qua cua so restore, bo dedupe v=202608311035 2026-08-31 10:35:59 +07:00
admin f6104a43d5 V45.11: fix SF preset wrong after reopen - preload SF2 gui program change (C++ loadSoundFontFile reset bank/program 0 moi lan load, JS khong gui lai) v=202608300815 2026-08-30 08:15:51 +07:00
admin e57b9fade2 V45.10: fix seek lag solo track - skip sink re-point on seek restart v=202608300814 2026-08-30 08:14:42 +07:00
admin 6b18d25520 V45.9: fix solo/un-solo khi play -> soundfont delay/wobble/crackle - updateSfRouting re-point bridge sink (AudioRoutingEngine.connect -> disconnect/reconnect gainNode FluidSynth) giua main play khi midiAudible count doi (2->1) = glitch ngay; skip sink re-point khi isPlayingRef (main/session), mute/solo da xu ly bang CC7 + track gain, routing set lai khi STOP; v=202608300750 2026-08-30 07:51:18 +07:00
admin 4c0987733e V45.8: fix Qin VST2 loop wrap crackle - wrap release them NOTE_OFF per-pitch (timelinePitchesRef) vi CC123 khong an voi VST2 (Qin bo qua all-notes-off CC) -> note cu ring qua seam re-trigger cung pitch = giat; per-note OFF da chung minh an (panic 128 noteOff o STOP, D18c); v=202608292315 2026-08-29 22:42:02 +07:00
admin 85fdcb16e2 V45.7b: fix TCP loading loop — _notifyStatus chi fire cb khi connected doi (poller queryStatus 400ms tung reset map + reload track -> LOAD skip vo han) 2026-08-29 22:11:00 +07:00
admin c0fbf29d41 V45.7: fix SF2 load fail fallback — catch bridgeLoad 404 so GM fallback runs 2026-08-29 22:04:37 +07:00
admin 945e63918d V45.6 fix solo Q3: bo stopAllPlayback+restart 60ms khi solo main-session (track solo giu nguyen tieng, het wobble re-attack); GIU timelinePitchesRef qua stop - kill branch NOTE_OFF tung pitch (Qin im khi solo track khac, truoc day tset=0); C++ allNotesOff sandbox VST2 qua control 7 (child panic local CC64/CC123+128 noteOff) thay 128 note-off flood queue 64-cap (Qin het treo sau STOP); IPC toggleSolo tu applyAllTrackMuteSolo (ref patch + kill); v=202608292138 2026-08-29 21:39:59 +07:00
admin 72ae22f865 V45.5 instrument solo path (Q3 debug): dbg log solo_toggle/solo_apply/solo_kill/solo_guard/play_tracks - lan test toi thay ro trang thai ref + note bi block; C++ [Vst2Sandbox] ON/OFF/CC log trong SandboxVst2Host (Qin chay sandbox, truoc day midi vao Qin hoan toan mu trong bridge.log - chi VST3 log [midi]), v=202608291806 2026-08-29 18:09:16 +07:00
admin 82796417c1 V45.4 fix SF loop wrap gap: worklet KEEP 4->16 (85ms che stall 68-82ms, het underrun wrap dien hinh) + wrap underrun bo flush (D17 da skip engine flush; worklet flush pha gap seam) + resumeFill 8 (~43ms) thay FILL 24 (~128ms) - gap wrap ~110-235ms giam con vai chuc ms, v=202608291752 2026-08-29 17:54:36 +07:00
admin 788a371f72 V45.3 fix Qin tremolo khi solo track khac: activeTracksRef luon ghi state da patch (bo restore STALE) - D18b guard/scheduler thay solo-out ngay, v=202608291749 2026-08-29 17:50:12 +07:00
admin f3fd0109a7 V45.2 fix Qin silence (20s audio-thread stall) + SF loop downbeat delay 
- SandboxVst2Host::loadSerializedState: queuePreset non-blocking (byte-identical
  echo never matched -> waitApply always burned 20s TIMEOUT on the audio thread;
  VST2 restore runs via runOnMain so every startup silenced ALL audio ~20s = Qin
  'failed that su'). Bridge now holds reloading + defers saveStateJob until the
  child republishes a different chunk (clobber protection, no audio block).
- sf-fx-realtime clear_queue('loop'): truncate old tail to KEEP=4 blocks
  (~21ms) instead of keeping FILL 24 (~128ms) -> wrap downbeat no longer ~110ms
  late; skipFade crossfade masks the truncation jump, seam crossfade recount.
- bump ?v= 202608291721 (app.jsx x2, index.html x2); deploy 3 _internal + dist.
 2026-08-29 17:25:32 +07:00
admin 6b26d5db0e V45.1: fix load VSTi loi ReferenceError instrumentSelectorData (module scope) - guard typeof undefined, v=202608290945 2026-08-29 16:46:05 +07:00
admin c084ac8ba7 V45: D17 seamless loop wrap + D18 stop solo note-off (Qin) + D18b/c guard + engine VST load fixes 
- D17: wrap_info/wrap-skip, fx wrap xfade, playhead-derived scheduling
- D18: solo stop -> NOTE_OFF all sounding timeline pitches + CC123/CC120
- D18b: track audible gain guard, tracksRef fallback
- D18c: timelinePitchesRef per-track Set, kill at applyAllTrackMuteSolo
- bridge ring _MAX 16, index v=202608290928
- plugins.py/vst_engine.py/fx_realtime.py/JuceFxEngine.cpp: VSTi load + Qin fixes (uncommitted 12:18)
 2026-08-29 16:39:02 +07:00
admin 2b334c0812 V46: FILL 48->96 (cushion ~512ms) chong stall ~500ms (u2 deficit 723ms) + instrument 3 lop (wl_gap/main_in_gap/pump_hb) 2026-08-29 09:01:35 +07:00
admin 2a3e5bf08f V45: tang FILL 24->48 (cushion 256ms) chong stall OS ~200ms (PDC 14080) 2026-08-29 08:00:22 +07:00
admin 2afa828c8f V44: fix crackle - uu tien audio thread bridge (HIGHEST) + FILL 24 (cushion ~90ms) PDC 7936 2026-08-28 17:22:50 +07:00
admin 8990f04357 V43: tang FILL 8->16 chong underrun crackle (cushion 3-8 -> 11-16) + PDC 5888 2026-08-28 16:36:13 +07:00
admin bf74a0be4f G3 deploy: mac dinh dung JUCE bridge + bundle juce_fx_bridge vao engine 2026-08-28 16:21:12 +07:00