Commit Graph

1190 Commits

Author SHA1 Message Date
admin db9123438d V45.45: fix GUI embed VST den tren box (Nectar/iZotope) - first-paint kick real click + BitBlt black-frame fallback + on-screen parking MAC DINH (SF_FXGUI_EMBED_ONSCREEN=0 de tat) + plugins.py log TAT CA stdout bridge (khong nuot dong truoc SF_FXGUI_PORT=) + auto-open GUI khi add VST FX vao Mastering slot. Rebuild daw_vst_bridge+fx_vst_bridge+installer NSIS. 2026-09-03 07:13:21 +07:00
admin f958348a20 V45.44: fix Ozone 11 GUI den tren Intel UHD 630 - env SF_FXGUI_EMBED_ONSCREEN giu window tren man hinh (HWND_BOTTOM tai rect panel, duoi DAW) de DWM redirect GPU surface thay vi park -20000 (PrintWindow chi capture duoc window dang tren monitor); EMBED_ONSCREEN tuong duong ATTACH_ONSCREEN (khong regress crash attach); /hide reset anchored/dance de reopen re-place dung; them SF_FXGUI_DEBUG=1 log [FxGuiDbg] moi 2s (served/capOk/okB/okP/avg/vis/rect/anchored) lam ground truth cho lan test toi; captureHwndToJpeg expose okB/okP. Rebuild daw_vst_bridge+fx_vst_bridge+installer NSIS. 2026-09-02 21:47:16 +07:00
admin 244dc8ee9e V45.43: fix Ozone 11 GUI crash on Intel UHD 630 + load diagnostics
Root-cause hypothesis: fx_vst_bridge parked embed window offscreen (-20000,-20000)
during VST3 editor attach; Ozone 11 GL init null-derefs (c0000005 in
iZOzone11Core.dll+18f6b92) on Intel ICD. Reaper hosts window on-screen -> OK.

- RenderFxJob.cpp: env toggle SF_FXGUI_ATTACH_ONSCREEN=1 -> SetWindowPos(100,100)
  before fxGuiLoadAttach, park back offscreen after attach succeeds
- main_fx.cpp: FxCrashDumpHandler prints [CRASH] in <module>+0x<offset> and
  [CRASH] minidump: <path> so logs name the faulting plugin DLL directly
- app.jsx VstGuiEmbed: frameLoadedRef + 90s watchdog -> onDead if bridge alive
  but no frame (no more infinite 'Dang tai plugin VST...' flash); clearer onDead
  toasts with %TEMP%\sf_dumps\fx_bridge_crash_*.dmp hint (track + master)
- rebuild fx_vst_bridge + daw_vst_bridge, NSIS/MSI v=202609021809
2026-09-02 21:08:49 +07:00
admin 9f3b072be0 V45.42: xoa toolbar label 'VST GUI - nhung (frame-capture)' trong VstGuiEmbed (GUI hien thi thang o row, khong con header bar) + fix flash trang khi load GUI embed o tang C++: RenderFxJob.cpp them global g_fxGuiEditorReady (set sau khi editor attach thanh cong tren pump thread), FxGuiServer.cpp /frame tu choi 503 khi chua ready, tinh mean-luma trong captureHwndToJpeg de loai frame trang/den (avg <0.02 hoac >0.98), cache g_lastGood de serve frame tot cuoi thay vi frame blank khi window dang repaint. Rebuild daw_vst_bridge+fx_vst_bridge+engine+installer NSIS/MSI v=202609021810. 2026-09-02 18:31:41 +07:00
admin 0da2a41330 Merge remote-tracking branch 'origin/main' 2026-09-02 17:46:12 +07:00
admin 328f3506bb V45.41: fix 4 loi Mastering Panel tren may khac - xoa toolbar Delta Listen (IRC/EQ Presets/Learn Input Gain), xoa nut 'X Dong GUI' VstGuiEmbed, GUI embed chi mo theo click (bo auto-open khi vao panel + bo persist _persistMasterGuiOpen), fix flash VST GUI bang frame preload single-flight + throttle /show theo rect, fix chip 'Server' nhap nhay (hysteresis: offline sau 3 fail lien tiep, timeout 6s). Rebuild engine+installer v=202609021718. 2026-09-02 17:40:07 +07:00
admin d8e5f52017 V45.40: fix bridge crash-dump hardcode duong dan may dev (C:/Users/locpham/...) -> %TEMP%\sf_dumps (GetTempPathA) - audit cross-machine. Rebuild bridge+engine+installer NSIS/MSI v=202609021627. 2026-09-02 16:50:02 +07:00
admin b153850d5c V45.39: fix installer khong cai VC++ redist -> VST FX 0x7E tren may sach
Root cause: bridges (/MD) import MSVCP140.dll/VCRUNTIME140*.dll nhung installer
KHONG bao gio cai VC++ redist. hooks.nsh dinh nghia macro 'customInstall'
- ten Tauri v2 khong goi (template dung NSIS_HOOK_POSTINSTALL) -> macro chet,
vc_redist.x64.exe khong duoc nhung, khong chay. May phat trien chay duoc vi
co MSVC BuildTools (redist san); may user sach: bridge khong start duoc ->
moi VST/VST3 FX khong load (GUI khong mo), plugin /MD khac (iZotope core...)
bao 0x7E.

Fix:
- hooks.nsh: doi macro thanh NSIS_HOOK_POSTINSTALL; vc_redist dong goi nhu
  bundle resource ->  (File tuong doi trong macro resolve theo thu muc
  installer.nsi sinh ra, khong phai src-tauri -  cung vay).
  ExecWait /install /quiet /norestart; xoa file sau khi cai xong (rc 0/3010).
- tauri.conf.json: resources + vc_redist.x64.exe; nsis installMode perMachine
  (vc_redist can elevation; DAW scan Program Files plugin dirs).

Verified: 7z l installer -> vc_redist.x64.exe embedded; installer.nsi insert
NSIS_HOOK_POSTINSTALL; INSTALLMODE perMachine; makensis OK. NSIS +387MB.
MSI (WiX) van khong cai redist - can cai tay tren may dung MSI.
2026-09-02 12:46:24 +07:00
admin 29b5f053a0 V45.38: suppress iZotope 0x7E dialog
- _is_vst2_dll: pure-Python PE export-table check (magic-aware dd offset
  PE32+112) -> IZOzone11Core.dll (runtime lib, no VSTPluginMain) dropped
  from VST2 lists in _scan_plugins and list_scan_all; plugins.py same.
- _hidden_desktop_startupinfo: scan subprocess runs on hidden desktop
  (user32 CreateDesktopW, HDESK restype) -> third-party MessageBox invisible.
- SetErrorMode(SEM_FAILCRITICALERRORS|SEM_NOOPENFILEERRORBOX) in all 4
  bridge mains: missing dependency DLL fails silently instead of blocking.
2026-09-01 20:10:33 +07:00
admin aee537a0af V45.37: rebuild installer full (frontend+engine+bridge) - NSIS+MSI moi chua V45.35 (Plugin Manager Scan) + V45.36 (SF2 preset fallback). Bump v=202609011809. 2026-09-01 18:33:45 +07:00
3dtours c8e2d0f6e2 V45.37: build_windows.ps1 full-build - dung path CMake build/bridge-win (vcxproj+Release), Continue+LASTEXITCODE (native stderr), kill engine theo path khong dong production 2026-09-01 12:26:04 +07:00
3dtours 855a753e26 V45.36: build_install.ps1 robust voi native stderr (Continue+LASTEXITCODE), kill theo path install/dist khong dong production 2026-09-01 12:12:18 +07:00
3dtours 400b5e5370 V45.35: fix build_install/build_windows copy layout PHANG - Copy-Item wildcard tran noi dung _internal ra root (exe treo luc chay); dung robocopy /MIR giu dung cau truc onedir exe+_internal 2026-09-01 11:44:06 +07:00
3dtours 1932467539 V45.34: ban cai phai SACH - engine.spec loai dev config (DB/.secret_key/plugin_dirs.json/sf_scan_state.json) khoi bundle; build_install.ps1 + build_windows.ps1 fail-fast neu dist dinh config dev (reset ve mac dinh cho nguoi dung moi) 2026-09-01 11:31:13 +07:00
locpham 4713f8a8a1 V45.33: fix Plugin Manager VSTi liệt kê nhầm VST FX (Ozone Pro/Tonal Balance Control Pro) làm instrument - /available chặn entry UNKNOWN theo tên (bridge timeout introspect VST3) + _norm_path_stem 2026-09-01 10:37:12 +07:00
admin 60a87626f0 V45.36: fix SF2 preset thieu tren soundfont non-GM (Cajon.sf2) - fluidsynth error 'There is no preset with bank number 0 and preset number 40/44' lam track violin/contrabass silent. selectProgram/programChange gio fallback 3 bac: (bank,program) -> (0,program) -> (0,0) thay vi chi bank128->bank0 (fluidsynth giu preset cu -> sai am). Rebuild daw_vst_bridge MSBuild 20260901-1003. 2026-09-01 10:03:55 +07:00
admin 5467c50fb7 V45.35: fix Plugin Manager scan - nut Scan (dirs list) onClick truyen SyntheticEvent lam dirsOverride -> dirs=event -> savePluginDirs({plugin_dirs: event}) -> Tauri invoke JSON.stringify gap __reactFiber$ circular (HTMLButtonElement) - loi 'Converting circular structure to JSON' khi scan Soundfont/VSTi. Fix: onClick: () => saveAndScanDirs(). v=202609010955 2026-09-01 09:56:19 +07:00
admin cb89d374ff V45.34: rebuild bundle v=202609010910 (build_windows.ps1 full - precompiled + index bump, sf-fx-realtime.js?v=202609010910) 2026-09-01 09:31:37 +07:00
admin 848bbf4d15 V45.33: rebuild bundle - bump v=202609010905 (precompiled + index, sf-fx-realtime.js?v=202609010905), rebuild 3 native bridge (daw_vst_bridge/fx_vst_bridge/plugin_host) tu source 20260831-2149 bang MSBuild 20260901-0905 2026-09-01 09:10:14 +07:00
admin 5f8844637e V45.32: fix (1) latency preview MIDI keyboard - flush ring bridge sink (bridgeAudioWorklet _MAX 32 ~170ms audio cu render truoc) tai idle->active live note-on trong __clearMasterFxQueue (cung dieu kien V45.26: _liveHeldCount===0 && im lang >500ms) de note moi nghe ngay; guard _timelinePlaying (khong flush khi timeline dang play); (2) crackle VST2 tremolo/loop - overrun crossfade tich luy moi block drop cong 256 mau cap 1024 (~21ms) thay vi co dinh 64 mau (1.3ms qua ngan -> blip/wow khi drop loat block o chord nhieu voice) (tai lap tu V45.28, giu ring 32 de latency thap). v=202608311858 2026-08-31 19:00:24 +07:00
admin 21cc8421a5 V45.31: REVERT V45.28 (4ed1de6) ve dung trang thai b64343a (V45.27) de kiem tra latency cao - ring worklet 32 block (~170ms), worklet URL v=202608311809, bo overrun crossfade tich luy 256/cap1024 cua V45.28. v=202608311809 2026-08-31 18:48:08 +07:00
admin 833f3bd158 V45.30: REVERT V45.29 (a069773) - V45.29 ring worklet 80 (~426ms) gay latency cao khi preview midi keyboard (ring luon day, do tre = dung ring cap) va crackle khi Chord VST2; quay ve V45.28 (4ed1de6): ring 48 (~256ms), worklet URL v=202608311820, bo log worklet_stats dinh ky. v=202608311820 2026-08-31 18:44:12 +07:00
admin a069773d4a V45.29: fix wobble preview VST2 chord van con sau V45.28 - ring worklet bridgeAudioWorklet 48->80 block (~426ms) phu stall render loop C++ toi ~361ms do tu log (fxrt_bridge loopMax=361ms, fxrt_pump pump_gap 362ms, longtask d=346): ring 48 (256ms) van khong du -> underrun lap lai fade ve 0 = wobble; them worklet_stats log dinh ky moi ~2s vao dbg.log (preview_diag chi fire keybed/vkb, duong preview khac khong log ws= duoc) de xac minh ov/un sau fix. v=202608311832 2026-08-31 18:32:37 +07:00
admin 4ed1de638d V45.28: fix wobble preview VST2 loop/tremolo khi nhan chord - ring worklet bridgeAudioWorklet 32->48 block (~256ms) hap thu stall render loop C++ khi chord nhieu voice (stall >170ms -> underrun lap lai fade ve 0 nghe nhu wobble; 16->32 V45.27 da dung crackle, 32 chua du cho chord); overrun crossfade tich luy moi block drop cong 256 mau cap 1024 (~21ms) thay vi co dinh 64 mau (1.3ms qua ngan -> blip/wow khi drop loat block o chord nhieu voice). v=202608311820 2026-08-31 18:20:53 +07:00
admin b64343aac6 V45.27: fix (1) PR tab preview cam khi sub-tab PR khong ARM - ARM MAIN/SECTION cuc bo, khong leak sang PR (3 nhanh: vkbNoteOn prArmedIds + attachMidiHandler bridge bPrArmed + SonicSF arSubs them && isArmed); (2) crackle preview VST2 instrument loop/tremolo - ring worklet bridgeAudioWorklet 16->32 block (~170ms) hap thu stall render loop C++ khi instrument xu li loop/tremolo nang CPU (8->16 truoc da dung tremolo, 16 chua du); them stats overrun/underrun tu worklet -> getDiag/preview_diag (ws=ov/un) de xac minh con crackle khong. v=202608311809 2026-08-31 18:10:47 +07:00
admin 72ae2c8a9a V45.26: fix wobble/crackle khi preview MIDI keyboard nhan (1/8 lien tuc) o MAIN/SECTION/PR tab. Root cause: unifiedMidiRouter.pushEvent clear master FX outQueue (__clearMasterFxQueue, V31 fix lag idle backlog ~341ms) tren MOI live NOTE_ON -> rapid notes: moi note wipe queue dang chua tail note truoc + resume fade-in 43ms -> cat tail (crackle) + fade nhap nhay (wobble). Fix: chi clear khi that su idle->active (khong con note dang giu VA im lang >500ms) — dem _liveHeldCount + _lastLiveEventAt; note dang ngan / chuoi note nhanh giu queue. Timeline (live=false) khong doi. v=202608311756 2026-08-31 17:56:17 +07:00
admin fbefa7e864 V45.25: fix ARM leak trong PR tab - preview chi track dang edit. Root cause: vkbNoteOn + attachMidiHandler (bridge bPrArmed va SonicSF arSubs) gom ARM tu TAT CA sub-tab PR (forEach s.isArmed) + track MAIN isArmed -> ARM track 1 leak sang PR tab track 2 (khong ARM) van nghe nhac cu track 1. Fix: trong PIANO_ROLL tab, target = duy nhat sub-tab PR dang active (activeTabRef), bat ke isArmed; MAIN/SECTION giu nguyen (ARM moi, khong ARM -> cam + toast). v=202608311739 2026-08-31 17:39:40 +07:00
admin cdf71078f8 V45.24: dao y/c - solo/mute CHI cuc bo MAIN/SECTION, PIANO ROLL TAB KHONG bi cam. REVERT V45.23 (4 gate computeTrackAudibleGain o preview) + lam PR doc lap: (1) scheduleMidiNoteDispatch them param prNote=true cho 6 nhanh PR (play, ghost, click, draw, brush, wheel) -> bo qua solo_guard + goi ensureTrackPrAudible (CC7=vol theo volumeDb bo qua mute/solo + setTrackNodeGain) tai thoi diem fire; (2) preview keybed vkbNoteOn + hardware attachMidiHandler (bridge + SonicSF fallback) khi _isPrTabNow goi ensureTrackPrAudible de channel khong con bi CC7=0 tu toggle MAIN; (3) applyAllTrackMuteSolo + sync useEffect bo qua gain=0/CC7=0/kill note khi track co sub-tab PR dang PLAY. Timeline MAIN giu solo_guard. v=202608311725 2026-08-31 17:26:08 +07:00
admin 6cd4eb423a V45.23: fix Bug 4 (solo/mute khong tac dung o PIANO ROLL tab) - preview MIDI (keybed vkbNoteOn + hardware attachMidiHandler NOTE_ON bridge/SonicSF fallback) bo qua trang thai mute/solo cua MAIN/SECTION context: track muted hoac solo-out van phat am khi bam phim o PR tab. Them gate computeTrackAudibleGain vao 4 nhanh preview (bTracks, arSubs, armedTracks, vkb targets) - dung semantics nhu scheduleMidiNoteDispatch solo_guard (timeline da dung tu V45.21). vkbNoteOff/note-off bridge KHONG gate (phai kill note dang giu khi mute giua chuong). marker solo_guard block midi ch= p= cho dbg. v=202608311716 2026-08-31 17:16:49 +07:00
admin 2fe78ddd1b V45.22: fix Bug 3 (wobble loop wrap) - wrap restart skipRouting nhu seekPlaybackTo/applyPlayheadDirect: updateSfRouting (AudioRoutingEngine.connect/ disconnect bridge sink + setOutputDestination) chay o MOI wrap trong luc isPlayingRef=false -> stall main thread 122-161ms (pump_gap) > KEEP 16 (~85ms) -> outQueue can -> underrun -> wobble beat 0:0 + playhead desync. skipRouting bo routing khoi critical path wrap -> stall ve duoi KEEP -> het underrun. Them instrument: stop_start log stack caller (xac nhan mystery stop = user Space/Stop, khong phai code) + wrap_timing stop=/start= phan tach stall. v=202608311708 2026-08-31 17:09:28 +07:00
admin 7572d339de V45.21: fix Bug 1 (seek delay - seek branch resumeFill=8 thay vi RESUME_FILL 24 ~128ms -> 43ms nhu wrap V45.4; applyPlayheadDirect stopAllPlayback(false,true) skipRouting nhu seekPlaybackTo) + Bug 2 (attachMidiHandler guard _isPrTabNow nhu vkbNoteOn V45.19 - ARM piano roll khong leak ra MAIN/SESSION) v=202608311642 2026-08-31 16:43:32 +07:00
admin 75b1512779 V45.20: fix Bug 6 (piano roll trang - bo subTabsRef/activeTabRef ngoai scope trong renderKeybed -> const _kbSilent=false; renderKeybed chi chay o PR tab nen luon false) + Bug 1 debug (them pitch vao log midi_push) v=202608311305 2026-08-31 13:04:00 +07:00
admin 36f2cf79b1 V45.19: fix Bug 1b (seek#2 + wrap freeze) + Bug 2 (ARM scope theo active tab) v=202608311242
- Bug 1b: worklet clear_queue nho clearMode; dbgPlayFirst post fx_seek_first khi
  mode=seek -> main snap khong can guard 50ms (seek resume nhanh ~43ms < 50ms).
- Bug 1b: loop wrap KHONG freeze playhead nua (chi re-anchor processed) -> het
  playhead dung ~1.5s sau wrap (truoc day freeze 1500ms fail-safe).
- Bug 2: vkbNoteOn chi gom ARM piano roll khi DANG o PIANO_ROLL tab; MAIN/SECTION
  khong ARM -> targets rong -> preview cam. renderKeybed silent flag tuong tu.
- DIAG: preview_diag them trg/prTab (vkb) + sl (keybed).
2026-08-31 12:43:08 +07:00
admin 8a6a79c757 V45.18: fix seek khi play master FX active - clear_queue mode 'seek' (wipe queue cu + resume nhanh 8 block ~43ms thay vi FILL 24 ~128ms) het am tre 1 beat; DIAG preview_diag src=keybed cho Bug 2 ARM piano roll v=202608311222 2026-08-31 12:25:01 +07:00
admin 8ccf7e4b14 V45.17: fix seek khi play master FX active - set startOffsetTimeRef + __fxRtPlayheadFreeze NGAY tai click (het 50ms dau playhead chay theo processed anchor cu truoc khi dung) v=202608311151 2026-08-31 11:52:23 +07:00
admin 80b8c3e034 V45.16: freeze playhead khi seek master FX active (het playhead chay truoc am ~128ms) v=202608311143 2026-08-31 11:43:21 +07:00
admin 39f00c3c0b V45.15: fix ARM piano roll khong am - gop subTab isArmed (PIANO_ROLL) vao 2 path gui note (midi_push bridge branch + vkbNoteOn) - preview note toi track dang edit du track main khong ARM v=202608311122 2026-08-31 11:23:34 +07:00
admin 752db690b3 V45.14: diag preview_audio - dem bridge-audio frames 500ms sau note-on (tach engine render vs JS routing) v=202608311112 2026-08-31 11:11:47 +07:00
admin ad71ac1168 V45.13: diag Bug 3/4 preview khong am - preview_diag tai vkbNoteOn (routing state, BridgeAudioNode.getDiag, masterBus, fxRt, arm/tab) + sf_route tai updateSfRouting (nhanh PR_CONNECT/SINGLE_CONNECT/MASTER_FALLBACK) v=202608311101 2026-08-31 11:05:13 +07:00
admin 845823a9df V45.12: fix SF preset wrong sau reopen (race C++ restore async ghi de program JS vua gui) - retry FORCE CC0/CC32/PROGRAM sau 1.5s/4s/8s qua cua so restore, bo dedupe v=202608311035 2026-08-31 10:35:59 +07:00
admin f6104a43d5 V45.11: fix SF preset wrong after reopen - preload SF2 gui program change (C++ loadSoundFontFile reset bank/program 0 moi lan load, JS khong gui lai) v=202608300815 2026-08-30 08:15:51 +07:00
admin e57b9fade2 V45.10: fix seek lag solo track - skip sink re-point on seek restart v=202608300814 2026-08-30 08:14:42 +07:00
admin 6b18d25520 V45.9: fix solo/un-solo khi play -> soundfont delay/wobble/crackle - updateSfRouting re-point bridge sink (AudioRoutingEngine.connect -> disconnect/reconnect gainNode FluidSynth) giua main play khi midiAudible count doi (2->1) = glitch ngay; skip sink re-point khi isPlayingRef (main/session), mute/solo da xu ly bang CC7 + track gain, routing set lai khi STOP; v=202608300750 2026-08-30 07:51:18 +07:00
admin 4c0987733e V45.8: fix Qin VST2 loop wrap crackle - wrap release them NOTE_OFF per-pitch (timelinePitchesRef) vi CC123 khong an voi VST2 (Qin bo qua all-notes-off CC) -> note cu ring qua seam re-trigger cung pitch = giat; per-note OFF da chung minh an (panic 128 noteOff o STOP, D18c); v=202608292315 2026-08-29 22:42:02 +07:00
admin 85fdcb16e2 V45.7b: fix TCP loading loop — _notifyStatus chi fire cb khi connected doi (poller queryStatus 400ms tung reset map + reload track -> LOAD skip vo han) 2026-08-29 22:11:00 +07:00
admin c0fbf29d41 V45.7: fix SF2 load fail fallback — catch bridgeLoad 404 so GM fallback runs 2026-08-29 22:04:37 +07:00
admin 945e63918d V45.6 fix solo Q3: bo stopAllPlayback+restart 60ms khi solo main-session (track solo giu nguyen tieng, het wobble re-attack); GIU timelinePitchesRef qua stop - kill branch NOTE_OFF tung pitch (Qin im khi solo track khac, truoc day tset=0); C++ allNotesOff sandbox VST2 qua control 7 (child panic local CC64/CC123+128 noteOff) thay 128 note-off flood queue 64-cap (Qin het treo sau STOP); IPC toggleSolo tu applyAllTrackMuteSolo (ref patch + kill); v=202608292138 2026-08-29 21:39:59 +07:00
admin 72ae22f865 V45.5 instrument solo path (Q3 debug): dbg log solo_toggle/solo_apply/solo_kill/solo_guard/play_tracks - lan test toi thay ro trang thai ref + note bi block; C++ [Vst2Sandbox] ON/OFF/CC log trong SandboxVst2Host (Qin chay sandbox, truoc day midi vao Qin hoan toan mu trong bridge.log - chi VST3 log [midi]), v=202608291806 2026-08-29 18:09:16 +07:00
admin 82796417c1 V45.4 fix SF loop wrap gap: worklet KEEP 4->16 (85ms che stall 68-82ms, het underrun wrap dien hinh) + wrap underrun bo flush (D17 da skip engine flush; worklet flush pha gap seam) + resumeFill 8 (~43ms) thay FILL 24 (~128ms) - gap wrap ~110-235ms giam con vai chuc ms, v=202608291752 2026-08-29 17:54:36 +07:00
admin a7630f0e6d chore: bo target/ root (artifact lan) khoi index + gitignore 2026-08-29 17:50:45 +07:00